Code Reviews¶

Volunteers¶

• Mike Gunderloy
• Zach Moazeni

Asking for help¶

1. Create a Github Gist with the code you want to go over
2. Ping the RailsBridge mailing list for help (including the gists)

Code Review Recaps¶

• People: Sarah Allen (coder), Zach Moazeni (reviewer)
• Topic: Using RSpec to test plugins
• Date: 5/24/2009
• Transcript: campfire
• Gists: https://gist.github.com/71a30f8d26928dfe9663, https://gist.github.com/cf7dff6a2620993654b8
• Take Aways
  • Check your assumptions if something "feels" wacky.
  • Sometimes you need to tell RSpec what "type" of spec it is
    • describe SomeClass, :type => :helper
    • but it is better to follow convention and put helper examples into spec/helper/
  • Changing ENV['RAILS_ENV'] can be dangerous. Instead push that type of logic into tiny classes.
  • Sometimes looking at how other projects solve problems can help frame your own solution
• Sarah's lessons learned blog post