CodeReviewStudents
Version 5 (Zach Moazeni, 05/24/2009 07:41 pm) → Version 6/8 (Zach Moazeni, 05/24/2009 07:47 pm)
h1. Code Reviews
h2. Volunteers
* Mike Gunderloy
* Zach Moazeni
h2. Asking for help
# Create a "Github Gist":http://gist.github.com/ with the code you want to go over
# Ping the "RailsBridge mailing list":http://groups.google.com/group/railsbridge for help (including the gists)
h2. Code Review Recaps
* People: Sarah Allen (coder), Zach Moazeni (reviewer)
* Topic: Using RSpec to test plugins
* Date: 5/24/2009
* Transcript: "campfire":http://wiki.railsbridge.org/attachments/1/transcript-sarah-zach-20090524.txt
* Gists: https://gist.github.com/71a30f8d26928dfe9663, https://gist.github.com/cf7dff6a2620993654b8
* Take Aways
** Check your assumptions if something "feels" wacky.
** Sometimes you need to tell RSpec what "type" of spec it is
*** @describe SomeClass, :type => :helper@
** Changing @ENV['RAILS_ENV']@ can be dangerous. Instead push that type of logic into tiny classes.
** Sometimes looking at how other projects solve problems can help frame your own solution problem