CodeReviewStudents
Version 1 (Zach Moazeni, 05/24/2009 07:16 pm)
| 1 | 1 | h1. Code Reviews |
|
|---|---|---|---|
| 2 | 1 | ||
| 3 | 1 | h2. Volunteers |
|
| 4 | 1 | ||
| 5 | 1 | * Mike Gunderloy |
|
| 6 | 1 | * Zach Moazeni |
|
| 7 | 1 | ||
| 8 | 1 | h2. Asking for help |
|
| 9 | 1 | ||
| 10 | 1 | # Create a "Github Gist":http://gist.github.com/ with the code you want to go over |
|
| 11 | 1 | # Ping the "RailsBridge mailing list":http://groups.google.com/group/railsbridge for help (including the gists) |
|
| 12 | 1 | ||
| 13 | 1 | h2. Code Review Recaps |
|
| 14 | 1 | ||
| 15 | 1 | * People: Sarah Allen (coder), Zach Moazeni (reviewer) |
|
| 16 | 1 | * Help: Using RSpec to test plugins |
|
| 17 | 1 | * Transcript: _link to transcripts_ |
|
| 18 | 1 | * Gists: _gist links_ |
|
| 19 | 1 | * Take Aways |
|
| 20 | 1 | ** Check your assumptions if something "feels" wacky. |
|
| 21 | 1 | ** Sometimes you need to tell RSpec what "type" of spec it is |
|
| 22 | 1 | *** @describe SomeClass, :type => :helper@ |
|
| 23 | 1 | ** Changing @ENV['RAILS_ENV']@ can be dangerous. Instead push that type of logic into tiny classes. |
|
| 24 | 1 | ** Sometimes looking at how other projects solve problems can help frame your own problem |